Rename CLI and ExecutableCLI folders by Mcrich23 · Pull Request #635 · apple/container

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Mcrich23

Copy link

Contributor

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

This is an extension of #603 to cleanup the folder structure and have it match with the new library and target names.

Testing

N/A

@Mcrich23

Copy link

Contributor Author

Here is the fixed version of #625 @jglogan.

@jglogan

Copy link

Contributor

jglogan commented

Sep 18, 2025

Don't forget to make the Property*.swift commands public too...

@Mcrich23

Copy link

Contributor Author

Done!

@jglogan jglogan linked an issue

Sep 18, 2025

that may be closed by this pull request

4 tasks

@jglogan

Copy link

Contributor

jglogan commented

Sep 18, 2025

@Mcrich23 make fmt.

Filed #639 to make life easier for all of us.

@Mcrich23

Copy link

Contributor Author

Sounds good. I did it before committing, so I find it funny that it needs to happen again. But I will do it in roughly 10 min.

@jglogan

Copy link

Contributor

jglogan commented

Sep 18, 2025

It looks like it was whitespace only. What IDE/editor are you using?

@jglogan

Copy link

Contributor

jglogan commented

Sep 18, 2025

Looks like there are compiler errors with the property subcommand changes.

@Mcrich23

Copy link

Contributor Author

It looks like it was whitespace only. What IDE/editor are you using?

Xcode

@Mcrich23

Copy link

Contributor Author

Looks like there are compiler errors with the property subcommand changes.

Fixing it right now.

@Mcrich23

Copy link

Contributor Author

Fixed

@Mcrich23

Copy link

Contributor Author

Ok, yay! I managed to get a hook working to auto-format before I push for the future

@jglogan jglogan merged commit 996a681 into apple:main

Sep 19, 2025

2 checks passed

@Mcrich23 Mcrich23 deleted the rename-cli-folder branch

September 19, 2025 00:49

@jglogan

Copy link

Contributor

jglogan commented

Sep 19, 2025

Merged, thanks for the contribution @Mcrich23!

Mcrich23 reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglogan jglogan jglogan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request]: TECH DEBT: Make CLI source directories consistent with target names.

2 participants

@Mcrich23 @jglogan