Propagate host ssh socket permissions to relay socket in guest. by jglogan · Pull Request #811 · apple/container
- Closes [Bug]:
--sshflag doesn't work with non-root user #580. - Depends on Use exact permissions for socket mount into guest. containerization#362.
Type of Change
- Bug fix
- New feature
- Breaking change
- Documentation update
Testing
- Tested locally
- Added/updated tests
- Added/updated docs
| if let socketUrl = Self.hostSocketUrl(config: config) { | ||
| if let socketUrl = Self.sshAuthSocketHostUrl(config: config) { | ||
| let socketPath = socketUrl.path(percentEncoded: false) | ||
| let attrs = try FileManager.default.attributesOfItem(atPath: socketPath) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we wanna handle the scenario when attributesOfItem throws?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, let's default to what we were doing before for that case as well
saehejkang pushed a commit to saehejkang/container that referenced this pull request
Oct 28, 2025…e#811) - Closes apple#580. - Depends on apple/containerization#362. ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Testing - [x] Tested locally - [ ] Added/updated tests - [ ] Added/updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters