Home Original page

fix AF object handling with podman container engine by neel-astro · Pull Request #1759 · astronomer/astro-cli

Conversation

@neel-astro

Description

Changes:

  • Pick the right container engine when running the AF objects related command, as of now we are hard-coded to docker, instead of picking the right container engine. This PR fixes that logic and adds error handling around it.

Describe the purpose of this pull request.

🎟 Issue(s)

Related #1724

🧪 Functional Testing

Added/updated applicable unit tests

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

schnie
stringOut := string(out)
return stringOut
return stringOut, nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed we're changing the function signature here and it got me wondering why this function didn't already return an error. Should we also return the error here on L32? - return errors.Wrapf(err, "error encountered executing airflow command") or something?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated the PR

schnie

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BasPH pushed a commit that referenced this pull request

Feb 20, 2025

2 participants

@neel-astro @schnie