update golang version to 1.23 for release workflow by pritt20 ยท Pull Request #1773 ยท astronomer/astro-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@pritt20

Copy link

Contributor

@pritt20 pritt20 commented

Jan 2, 2025

Description

The goreleaser pipeline seems to be failing because of outdated golang version: https://app.circleci.com/pipelines/github/astronomer/astro-cli/6085/workflows/a3e8c53e-726f-448b-ad22-4c8c73c841e4/jobs/12653

๐ŸŽŸ Issue(s)

Related #XXX

๐Ÿงช Functional Testing

List the functional testing steps to confirm this feature or fix.

๐Ÿ“ธ Screenshots

Add screenshots to illustrate the validity of these changes.

๐Ÿ“‹ Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation
Copy link

Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ๐Ÿ™‚

@neel-astro neel-astro merged commit b9d6fb6 into main

Jan 2, 2025

@neel-astro neel-astro deleted the update_golang_version branch

January 2, 2025 09:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neel-astro neel-astro neel-astro approved these changes

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pritt20 @neel-astro