Home Original page

1. Use the imagename tag to push to the registry if it is passed. 2. Fixed the logic to get image sha after push by rujhan-arora-astronomer · Pull Request #1782 · astronomer/astro-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rujhan-arora-astronomer

Copy link

Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented

Jan 9, 2025

•

edited

Loading

Description

  1. Use the image name tag to push to the registry if it is passed.
  2. Fixed the logic to get image SHA after push. Since the repoDigest gets deleted after the newly tagged image gets deleted, we need to grab it before deletion.

🎟 Issue(s)

https://github.com/astronomer/issues/issues/6768

🧪 Functional Testing

Locally -

  1. astro deploy --image-name electromagnetic-ionosphere-6312/airflow:test3
    For this command, the image pushed to the registry had the tag test3
  2. When private registry is enabled and sha_as_tag is true, it is calling the Houston updateDeploymentImage endpoint using the image SHA and not the tag.

Unit tests

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation
Copy link

Contributor

@neel-astro neel-astro left a comment •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we describe the manual tests done for this change in the PR description, this just makes the reviewer's life much easier to understand the change in general

…ePush to resolve cognitive complexity linting error

@neel-astro neel-astro merged commit 210e8b4 into main

Jan 10, 2025

@neel-astro neel-astro deleted the 6768_v2 branch

January 10, 2025 07:49

neel-astro pushed a commit that referenced this pull request

Jan 10, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neel-astro neel-astro neel-astro approved these changes

@jeremybeard jeremybeard Awaiting requested review from jeremybeard

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rujhan-arora-astronomer @neel-astro