Improve dev start UI message by jeremybeard · Pull Request #1833 · astronomer/astro-cli
Navigation Menu
{{ message }}
astronomer / astro-cli Public
- Notifications You must be signed in to change notification settings
- Fork 106
Merged
Improve dev start UI message#1833
jeremybeard merged 2 commits intomainfrom
Improve dev start UI message#1833
jeremybeard merged 2 commits intomainfrom
Conversation
Copy link
Contributor
jeremybeard
commented
Apr 14, 2025
jeremybeard
commented
Description
This improves the messages printed by astro dev start for Airflow 3, by:
- Referring to the "UI" instead of the "webserver"
- Using the API server port config instead of the webserver port config, for Airflow 3 images
- Not printing UI credentials for Airflow 3, because those are not required
📸 Screenshots
📋 Checklist
- Rebased from the main (or release if patching) branch (before testing)
- Ran
make testbefore taking out of draft - Ran
make lintbefore taking out of draft - Added/updated applicable tests
- Tested against Astro-API (if necessary).
- Tested against Houston-API and Astronomer (if necessary).
- Communicated to/tagged owners of respective clients potentially impacted by these changes.
- Updated any related documentation
jeremybeard
requested review from
kushalmalani and
neel-astro
as code owners
neel-astro approved these changes Apr 15, 2025
Copy link
Contributor
neel-astro
left a comment
neel-astro
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jeremybeard
deleted the
dev-start-webserver-message
branch
neel-astro pushed a commit that referenced this pull request
Apr 15, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
