Improve dev start UI message by jeremybeard · Pull Request #1833 · astronomer/astro-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jeremybeard

Copy link

Contributor

Description

This improves the messages printed by astro dev start for Airflow 3, by:

  • Referring to the "UI" instead of the "webserver"
  • Using the API server port config instead of the webserver port config, for Airflow 3 images
  • Not printing UI credentials for Airflow 3, because those are not required

📸 Screenshots

Screenshot 2025-04-14 at 2 47 20 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation
neel-astro reacted with thumbs up emoji
Copy link

Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremybeard jeremybeard merged commit 064aa21 into main

Apr 15, 2025

3 of 4 checks passed

@jeremybeard jeremybeard deleted the dev-start-webserver-message branch

April 15, 2025 13:56

neel-astro pushed a commit that referenced this pull request

Apr 15, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neel-astro neel-astro neel-astro approved these changes

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremybeard @neel-astro