Lint entire project, not just dags dir by jeremybeard · Pull Request #1840 · astronomer/astro-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jeremybeard

Copy link

Contributor

Description

This changes the new ruff linting feature for astro dev upgrade-test to lint the entire project, not just the dags/ directory. This will capture issues in other files such as in include/.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@jeremybeard jeremybeard merged commit ad0ffeb into main

Apr 18, 2025

3 of 4 checks passed

@jeremybeard jeremybeard deleted the lint-whole-project branch

April 18, 2025 17:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neel-astro neel-astro neel-astro approved these changes

@kushalmalani kushalmalani Awaiting requested review from kushalmalani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremybeard @neel-astro