Add remote execution config to deployment create/update/inspect commands by feluelle · Pull Request #1874 · astronomer/astro-cli
Conversation
Description
Describe the purpose of this pull request.
This is to support the Remote Execution configuration for Astro Executor Deployments in the CLI.
🎟 Issue(s)
closes: #1853
🧪 Functional Testing
List the functional testing steps to confirm this feature or fix.
📸 Screenshots
Add screenshots to illustrate the validity of these changes.
📋 Checklist
- Rebased from the main (or release if patching) branch (before testing)
- Ran
make testbefore taking out of draft - Ran
make lintbefore taking out of draft - Added/updated applicable tests
- Tested against Astro-API (if necessary).
- Tested against Houston-API and Astronomer (if necessary).
- Communicated to/tagged owners of respective clients potentially impacted by these changes.
- Updated any related documentation
jaketf
left a comment
•
Loading
jaketf
left a comment
•
Loading
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question about option log args on create
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, otherwise looks straightforward.
feluelle
deleted the
feature/deployment-create-update-args-remote-execution
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters