[Fix]: per deployment docker login by pgvishnuram · Pull Request #1945 · astronomer/astro-cli
Navigation Menu
{{ message }}
astronomer / astro-cli Public
- Notifications You must be signed in to change notification settings
- Fork 106
Merged
Conversation
Copy link
Contributor
Description
Describe the purpose of this pull request.
🎟 Issue(s)
https://github.com/astronomer/issues/issues/7903
https://github.com/astronomer/issues/issues/7944
🧪 Functional Testing
List the functional testing steps to confirm this feature or fix.
📸 Screenshots
Add screenshots to illustrate the validity of these changes.
📋 Checklist
- Rebased from the main (or release if patching) branch (before testing)
- Ran
make testbefore taking out of draft - Ran
make lintbefore taking out of draft - Added/updated applicable tests
- Tested against Astro-API (if necessary).
- Tested against Houston-API and Astronomer (if necessary).
- Communicated to/tagged owners of respective clients potentially impacted by these changes.
- Updated any related documentation
pgvishnuram added 2 commits
September 27, 2025 03:49
pgvishnuram
changed the title
fix docker login
[Fix]: per deployment docker login
pgvishnuram added 2 commits
October 3, 2025 19:32ianbuss reviewed Oct 3, 2025
software/deploy/deploy.go
Outdated
Show resolved
Hide resolved
software/deploy/deploy.go Outdated Show resolved Hide resolved
pgvishnuram added 3 commits
October 3, 2025 20:07ianbuss approved these changes Oct 3, 2025
Copy link
Contributor
ianbuss
left a comment
ianbuss
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with nit.
software/auth/auth.go
Outdated
Show resolved
Hide resolved
software/auth/auth.go Outdated Show resolved Hide resolved
Copy link
Contributor
ianbuss
commented
Oct 3, 2025
ianbuss commented
Oct 3, 2025Approved with nit.
Any tests need updating/adding?
ianbuss added 2 commits
October 3, 2025 18:33
Copy link
Pull Request Test Coverage Report for Build 1ecdcaa8-dbb0-4ff9-8063-ec1ef1285613
Details
- 23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
- 3 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.02%) to 38.294%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| software/deploy/deploy.go | 1 | 89.35% |
| docker/docker.go | 2 | 46.81% |
| Totals | |
|---|---|
| Change from base Build 749c30b6-5e3d-48ab-9e7d-a8679049ec15: | 0.02% |
| Covered Lines: | 23892 |
| Relevant Lines: | 62391 |
💛 - Coveralls
pgvishnuram added 3 commits
October 4, 2025 00:29
pgvishnuram
marked this pull request as ready for review
pgvishnuram
requested a review
from karankhanchandani
as a code owner
pgvishnuram and others added 2 commits
October 4, 2025 01:42ianbuss reviewed Oct 3, 2025
software/auth/auth.go
Outdated
Show resolved
Hide resolved
software/auth/auth.go Outdated Show resolved Hide resolved
neel-astro reviewed Oct 6, 2025
software/auth/auth.go
Outdated
Show resolved
Hide resolved
software/auth/auth.go Outdated Show resolved Hide resolved
software/auth/auth_test.go
Show resolved
Hide resolved
software/auth/auth_test.go Show resolved Hide resolved
pgvishnuram and others added 5 commits
October 6, 2025 20:46
ianbuss
deleted the
feat/fix-perdb-registry-login
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants