MAINT: adding Python 3.13 to CI by bsipocz · Pull Request #3088 · astropy/astroquery
Navigation Menu
{{ message }}
astropy / astroquery Public
- Notifications You must be signed in to change notification settings
- Fork 435
Merged
MAINT: adding Python 3.13 to CI#3088
bsipocz merged 2 commits intoastropy:mainfrom
MAINT: adding Python 3.13 to CI#3088
bsipocz merged 2 commits intoastropy:mainfrom
Conversation
Copy link Copy Markdown
Member
If we're compatible out of the box then no changelog entry will be needed...
(locally I see one doctesting whitespace issue, it may actually be an upstream doctestplus issue)
bsipocz
added
the
no-changelog-entry-needed
label
bsipocz
added this to the
v0.4.8 milestone
bsipocz
mentioned this pull request
Copy link Copy Markdown
Member
pllim
commented
Aug 27, 2024
pllim commented
Aug 27, 2024I think the whitespace problem is from Python 3.13 itself. According to https://docs.python.org/3.13/whatsnew/3.13.html, "The compiler now strips common leading whitespace from every line in a docstring."
Is there a reason why you must keep the leading whitespace? If not, would be much simpler to adjust the test for Python 3.13 and later. FYI.
Copy link Copy Markdown
Member Author
bsipocz
commented
Aug 27, 2024
bsipocz commented
Aug 27, 2024A good to know, thanks, I'll change the test then.
Copy link Copy Markdown
Member Author
bsipocz
commented
Aug 27, 2024
bsipocz commented
Aug 27, 2024This now has a pragmatic workaround for python/cpython#81283
pllim reviewed Aug 27, 2024
tox.ini
Show resolved
Hide resolved
bsipocz
merged commit
01c4d29
into
astropy:main
bsipocz
deleted the
MAINT_py313
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment