Home Original page

feat: remove Python3.7 support by texastony · Pull Request #648 · aws/aws-encryption-sdk-python

Conversation

@texastony

Issue #, if available:

Description of changes:

  • Stop testing or advertising support for py3.7
  • Tell PyPi we support 3.10, 3.11, 3.12

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony texastony changed the title chore: remove py3.7 testing feat: remove Python3.7 support

Mar 2, 2024

@texastony

On Approval, we should remove Python3.7 from required Checks.

lucasmcdonald3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important.
Question: Can we also remove appveyor.yml as part of this change?

@texastony

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important. Question: Can we also remove appveyor.yml as part of this change?

All these asks are reasonable.
I am not going to work on them right now, as I need to focus on my sprint work.
But the On Call or anyone can push to this branch to address these.

@ShubhamChaturvedi7

Looks good, there's some other spots in the tests we should clean up as well, but those aren't as important. Question: Can we also remove appveyor.yml as part of this change?

Already removed here: e28d146

lucasmcdonald3