Modified few dependencies to resolve windows build issues by LikithaVemulapalli · Pull Request #1062 · aws/aws-node-termination-handler

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@LikithaVemulapalli

Copy link Copy Markdown

Contributor

Issue #, if available:

  • Windows build failed after windows and dependabot PR's are merged.

Description of changes:

  • Modified few dependency versions to resolve the build issues.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LikithaVemulapalli LikithaVemulapalli marked this pull request as ready for review

September 4, 2024 22:33

@LikithaVemulapalli LikithaVemulapalli requested a review from a team as a code owner

September 4, 2024 22:33
Copy link Copy Markdown

Contributor

@Lu-David Lu-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LikithaVemulapalli LikithaVemulapalli merged commit bc75e65 into aws:main

Sep 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lu-David Lu-David Lu-David approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LikithaVemulapalli @Lu-David @ec2-bot