Imds asg lifecycle support by Lu-David · Pull Request #1067 · aws/aws-node-termination-handler
Navigation Menu
{{ message }}
aws / aws-node-termination-handler Public
generated from amazon-archives/__template_Apache-2.0
- Notifications You must be signed in to change notification settings
- Fork 277
Merged
Imds asg lifecycle support#1067
Imds asg lifecycle support#1067
Conversation
Copy link Copy Markdown
Contributor
Issue #837
Description of changes:
- Functionality for asg lifecycle in imds mode
- unit tests for asg lifecycle
- end-to-end tests for asg lifecycle
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
pete911 and others added 10 commits
May 19, 2023 20:54
Lu-David
changed the title
Imds asg lifecycle
Imds asg lifecycle support
Lu-David
requested review from
LikithaVemulapalli and
steveshidev
Lu-David
marked this pull request as ready for review
Lu-David
requested a review
from a team
as a code owner
LikithaVemulapalli approved these changes Sep 12, 2024
Copy link Copy Markdown
Contributor
LikithaVemulapalli
left a comment
LikithaVemulapalli
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on e2e test script! LGTM
Lu-David
merged commit
83a836d
into
aws:main
LikithaVemulapalli
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants