Fix 86 CodeQL findings across Go, Python, and CI workflows by jeremy · Pull Request #177 · basecamp/basecamp-cli
AI review requested due to automatic review settings
March 3, 2026 07:34Copilot AI review requested due to automatic review settings
March 3, 2026 07:52Apply filepath.Clean() at source functions where environment variables
(XDG_CONFIG_HOME, XDG_CACHE_HOME, HOME) and OS APIs (UserHomeDir,
UserCacheDir, UserConfigDir) produce tainted values. This breaks
CodeQL's taint chain for ~69 downstream path-injection findings.
Uses "fallback first, then clean non-empty" pattern to avoid
filepath.Clean("") returning "." which would redirect to CWD.
Falls back to os.TempDir() when home directory is unavailable.
exec.LookPath() is recognized by CodeQL as a sanitizer for the command-injection finding on $EDITOR-derived exec.Command calls.
… integer-overflow float64 can only represent consecutive integers exactly up to 2^53. Check range before casting to int64 to avoid undefined behavior for large floats. Adds boundary tests for precision edge cases.
Copilot AI review requested due to automatic review settings
March 3, 2026 08:08This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters