fix: correctly find runfiles root for symlinks by lpulley · Pull Request #2665

fix: correctly find runfiles root for symlinks by lpulley · Pull Request #2665 · bazel-contrib/rules_python

Conversation

$maybe_runfiles_root doesn't seem to be a real variable. Based on the presence of the while loop, it seems that this code wants to try resolving the symlink one level at a time (readlink, not realpath) until it can find runfiles?

Thanks for the contribution. Would it be possible to add a test of some sort to check for regressions in the future? If there is no good place, feel free to create //tests/runfiles package and put it there.

Let me know what you think of 2e03584!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this LGTM, let me re-kick the CI.

lpulley deleted the fix-stage1-bootstrap-following-symlink branch

March 24, 2025 02:40

Conversation

Choose a reason for hiding this comment

2 participants