chore: remove unnecessary DEFAULT_BOOTSTRAP_TEMPLATE global by rickeylev · Pull Request #2744 · bazel-contrib/rules_python
Navigation Menu
{{ message }}
bazel-contrib / rules_python Public
- Notifications You must be signed in to change notification settings
- Fork 676
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom
Apr 6, 2025Merged
Conversation
Copy link
Collaborator
rickeylev
commented
Apr 5, 2025
rickeylev
commented
I think the DEFAULT_BOOTSTRAP_TEMPLATE global was used by something in the original
Bazel impl, but now it's just used in one place. Remove the shared global and just
inline the single usage.
rickeylev
requested a review
from aignas
as a code owner
rickeylev
enabled auto-merge
rickeylev
force-pushed
the
chore.rm.default.bootstrap.global
branch
from
2230d7d to
7a82854
Compare
groodt approved these changes Apr 5, 2025
Copy link
Collaborator
groodt
left a comment
groodt
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rickeylev
added this pull request to the merge queue
rickeylev
deleted the
chore.rm.default.bootstrap.global
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants