fix: Resolve incorrect platform specific dependency by ewianda · Pull Request #2766

fix: Resolve incorrect platform specific dependency by ewianda · Pull Request #2766 · bazel-contrib/rules_python

aignas added a commit to aignas/rules_python that referenced this pull request

Apr 10, 2025

These are just bugfixes to already merged code:
* Fix nested bracket parsing in PEP508 marker parser.
* Fix the sys_platform constants, which I noticed in bazel-contrib#2629 but they got
  also pointed out in bazel-contrib#2766.
* Port some of python tests for requirement parsing and improve the
  implementation. Those tests will be removed in bazel-contrib#2629.
* Move the platform related code to a separate file.

All of the bug fixes have added tests.

Work towards bazel-contrib#2423.

aignas added a commit to aignas/rules_python that referenced this pull request

Apr 10, 2025

These are just bugfixes to already merged code:
* Fix nested bracket parsing in PEP508 marker parser.
* Fix the sys_platform constants, which I noticed in bazel-contrib#2629 but they got
  also pointed out in bazel-contrib#2766.
* Port some of python tests for requirement parsing and improve the
  implementation. Those tests will be removed in bazel-contrib#2629.
* Move the platform related code to a separate file.
* Rename `pep508_req.bzl` to `pep508_requirement.bzl` to follow the
  convention.

All of the bug fixes have added tests.

Work towards bazel-contrib#2423.

github-merge-queue bot pushed a commit that referenced this pull request

Apr 10, 2025

These are just bugfixes to already merged code:
* Fix nested bracket parsing in PEP508 marker parser.
* Fix the sys_platform constants, which I noticed in #2629 but they got
  also pointed out in #2766.
* Port some of python tests for requirement parsing and improve the
  implementation. Those tests will be removed in #2629.
* Move the platform related code to a separate file.
* Rename `pep508_req.bzl` to `pep508_requirement.bzl` to follow the
  convention.


All of the bug fixes have added tests.

Work towards #2423.

Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>

ewianda deleted the fix-incorrect-platform-specific-dependency branch

April 12, 2025 15:19