fix(rules): make the srcs trully optional by aignas · Pull Request #2768 · bazel-contrib/rules_python
Navigation Menu
{{ message }}
bazel-contrib / rules_python Public
- Notifications You must be signed in to change notification settings
- Fork 676
Merged
aignas merged 6 commits intobazel-contrib:mainfrom
Apr 13, 2025Merged
fix(rules): make the srcs trully optional#2768
aignas merged 6 commits intobazel-contrib:mainfrom
fix(rules): make the srcs trully optional#2768
aignas merged 6 commits intobazel-contrib:mainfrom
Conversation
Copy link
Collaborator
With this PR we mark the srcs attribute as optional as we can
leverage the main_module to just run things from the deps.
This also removes a long-standing TODO note.
Fixes #2765
With this PR we mark the srcs attribute as optional as we can leverage the `main_module` to just run things from the deps. Fixes bazel-contrib#2765
aignas
requested a review
from rickeylev
as a code owner
aignas commented Apr 11, 2025
python/private/py_executable.bzl
Outdated
Show resolved
Hide resolved
python/private/py_executable.bzl Outdated Show resolved Hide resolved
python/private/py_executable.bzl
Outdated
Show resolved
Hide resolved
python/private/py_executable.bzl Outdated Show resolved Hide resolved
aignas and others added 3 commits
April 11, 2025 09:33rickeylev approved these changes Apr 13, 2025
Copy link
Collaborator
rickeylev
left a comment
rickeylev
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the tests, otherwise LGTM
aignas
added this pull request to the merge queue
aignas
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants