fix(rules): copy_propagating_kwargs() now also copies target_compatible_with by dws · Pull Request #2788 · bazel-contrib/rules_python

@dws

…le_with

This routine already copies `compatible_with`, which is little used,
but does not copy `target_compatible_with`, which is broadly used.
This seems like an oversight.

I noticed this discrepancy when working on a system that assumes
that any `tags` or `target_compatible_with` parameters supplied
to a macro will propagate to all rules created by that macro.
In rules_python, this already works for `tags`, but not for
`target_compatible_with`.

It would be great to get this accepted upstream, so that I can
stop patching rules_python.

@dws dws changed the title fix: copy_propagating_kwargs() now also copies target_compatible_with fix(rules): copy_propagating_kwargs() now also copies target_compatible_with

Apr 18, 2025

@rickeylev rickeylev marked this pull request as ready for review

April 18, 2025 19:55

@rickeylev

rickeylev