refactor(repo_utils): create a helper for extracting files by aignas · Pull Request #3459 · bazel-contrib/rules_python

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the wheel extraction mechanism within the rules_python repository by introducing a shared utility function. This change centralizes the logic for handling .whl file extraction, including a specific workaround for older Bazel versions that do not natively support .whl extraction. The primary goal is to improve code maintainability and simplify future updates related to wheel processing by consolidating common extraction patterns into a single, reusable helper.

Highlights

  • Centralized Wheel Extraction Logic: A new _extract helper function has been introduced in python/private/repo_utils.bzl to consolidate the logic for extracting archive files, particularly Python Wheel (.whl) files.
  • Bazel 7 Compatibility Encapsulated: The new _extract helper now encapsulates the workaround for Bazel 7, which involves symlinking .whl files to .zip files before extraction, based on the supports_whl_extraction configuration flag.
  • Refactored Wheel Handling Modules: The patch_whl.bzl and whl_library.bzl modules have been updated to utilize the new repo_utils.extract helper, simplifying their internal logic for wheel extraction and removing redundant code.
  • Configuration Dependency Added: A new dependency on @rules_python_internal//:rules_python_config_bzl has been added to python/private/pypi/BUILD.bazel and patch_whl.bzl to access the rp_config.supports_whl_extraction flag, which guides the behavior of the new extraction helper.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.