refactor: remove most of semantics by rickeylev · Pull Request #3475 · bazel-contrib/rules_python
Summary of Changes
Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request undertakes a significant refactoring effort to remove the majority of "semantics" plugin objects from the Python rules. These objects were initially introduced to facilitate extensions for an internal Google implementation but are no longer serving their original purpose effectively. The py_library rule has been completely decoupled from this semantics system, and the py_binary rule has seen its semantics substantially streamlined, retaining only specific hooks for debugging, build data, and C++ dependencies. The overall goal is to simplify the codebase by removing an obsolete abstraction layer.
Highlights
- Complete Removal of py_library Semantics: The
LibrarySemanticsstruct and all associated logic have been entirely eliminated, simplifying the implementation of thepy_libraryrule by removing an unnecessary abstraction layer. - Streamlined py_binary Semantics: The
BinarySemanticsstruct has been significantly reduced in scope, with many parameters and functions removed. It now retains only essential hooks for debugger support, build data generation, and C++ dependencies. - Direct Function Calls: Functions previously accessed through the
semanticsobject, such asget_imports,maybe_precompile, andis_stamping_enabled, are now called directly. This change reduces indirection and simplifies the codebase.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩