fix: Quote all files if original RECORD had all files quoted by lalten · Pull Request #3515

fix: Quote all files if original RECORD had all files quoted by lalten · Pull Request #3515 · bazel-contrib/rules_python

Summary of Changes

Hello @lalten, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where repack_whl.py generated excessively large diffs for RECORD.patch files, particularly when dealing with wheels like PyTorch that consistently quote all filenames in their RECORD files. The changes introduce a mechanism to detect the original quoting style and ensure the repacked RECORD file adheres to it, significantly reducing the size and noise of generated patches and improving the efficiency of the patching process.

Highlights

Consistent RECORD file quoting: Introduced logic to detect if an original RECORD file had all filenames quoted and, if so, ensures the repacked RECORD file maintains this quoting style. This prevents large, unnecessary diffs in RECORD.patch files.
Refactored wheelmaker.py: The _WhlFile class now accepts a quote_all_filenames parameter. A new helper method _quote_filename was added to handle conditional quoting, utilizing csv.writer for standard quoting and applying additional quotes when quote_all_filenames is true.
Improved RECORD file generation: The process for generating the RECORD file has been updated to use string manipulation and the new _quote_filename method, making the output more consistent with the original file's format.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩