feat: add py_zipapp_binary and test rules for zipapp support by rickeylev · Pull Request #3539 · bazel-contrib/rules_python
Summary of Changes
Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a comprehensive overhaul of Python zip application (zipapp) support within the Bazel rules. By extracting zipapp creation into new, dedicated py_zipapp_binary and py_zipapp_test rules, the change aims to provide a more robust, feature-rich, and performant mechanism for packaging Python applications. It enhances control over the build process, improves determinism, and lays the groundwork for future advancements in Python binary distribution.
Highlights
- New Zipapp Rules Introduced: Dedicated
py_zipapp_binaryandpy_zipapp_testrules have been added to replace the existing zipapp logic withinpy_binaryandpy_test. These new rules offer enhanced functionality and improved build performance. - Improved Zipapp Features: The new zipapp rules provide explicit control over compression levels, optimize re-unzipping by checking the zip's hash, ensure more deterministic zip output, and support various symlink types (runfiles.symlinks, runfiles.root_symlinks, and raw symlinks). They also support zipping venv-based binaries.
- Output and Executability: Generated zipapps now have a
.pyzextension, and their executability is controlled via a dedicated attribute rather than a flag, offering more granular control. - Refactored Internal Logic: Significant internal refactoring has occurred, including the introduction of
maybe_create_repo_mappingandactions_runfunctions incommon.bzl, and a more detailedPyExecutableInfoprovider to support the new zipapp structure and its various components likeapp_runfilesandstage2_bootstrap. - New Tools and Templates: New Python scripts (
zipper.py,exe_zip_maker.py) and shell/Python templates (zip_shell_template.sh,zipapp_stage2_bootstrap_template.py) have been added to facilitate the creation and execution of these advanced zipapps.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩