Home Original page

feat(pypi): Use target_compatible_with in package aliases by nahueespinosa · Pull Request #3586 · bazel-contrib/rules_python

Summary of Changes

Hello @nahueespinosa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to how Bazel handles Python package compatibility within multi-Python environments. By leveraging Bazel's target_compatible_with attribute for pypi aliases, the system can now intelligently identify and skip targets that are not compatible with specific Python toolchains, thereby enhancing build stability and flexibility without causing complete build failures.

Highlights

  • Enhanced Python Package Compatibility: Introduced the use of target_compatible_with in pypi package aliases. This mechanism allows Bazel to gracefully handle packages that are not compatible across all defined Python toolchains, preventing hard errors during wildcard builds.
  • Improved Multi-Python Environment Handling: When multiple Python toolchains are present, Bazel can now skip incompatible targets rather than failing the entire build invocation, leading to more robust and flexible multi-Python project setups.
  • Proof of Concept Implementation: Demonstrated the functionality by modifying the websockets package constraint in the multi_python_versions example, effectively excluding it from Python 3.10 and showing how bazel test //... correctly skips incompatible targets.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • examples/multi_python_versions/requirements/requirements.in
    • Updated the websockets package constraint from python_full_version > "3.9.1" to python_full_version > "3.11".
  • examples/multi_python_versions/requirements/requirements_lock_3_10.txt
    • Removed the websockets package entry and its associated hashes, reflecting its incompatibility with Python 3.10 under the new constraint.
  • examples/multi_python_versions/requirements/requirements_lock_3_11.txt
    • Updated the websockets package constraint from python_full_version > "3.9.1" to python_full_version > "3.11".
  • examples/multi_python_versions/requirements/requirements_lock_3_12.txt
    • Updated the websockets package constraint from python_full_version > "3.9.1" to python_full_version > "3.11".
  • examples/multi_python_versions/requirements/requirements_lock_3_13.txt
    • Updated the websockets package constraint from python_full_version > "3.9.1" to python_full_version > "3.11".
  • examples/multi_python_versions/requirements/requirements_lock_3_14.txt
    • Updated the websockets package constraint from python_full_version > "3.9.1" to python_full_version > "3.11".
  • python/private/pypi/pkg_aliases.bzl
    • Added logic to conditionally set target_compatible_with for alias rules when the actual attribute is a dictionary, marking targets as incompatible by default unless explicitly compatible with a specific platform.
  • tests/pypi/pkg_aliases/pkg_aliases_test.bzl
    • Modified the mock alias functions in various test cases to accept the new target_compatible_with keyword argument, ensuring test compatibility with the updated pkg_aliases rule.
Activity
  • No activity recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩