feat(pypi): make whl_library reproducible under pipstar (#3589) by rickeylev · Pull Request #3632 · bazel-contrib/rules_python
Summary of Changes
Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the whl_library rule to support reproducibility, which is crucial for leveraging remote caching mechanisms effectively. By conditionally marking the repository as reproducible when pipstar extraction is enabled, it ensures more consistent and cache-friendly builds. The accompanying documentation update clarifies these new conditions for users.
Highlights
- Reproducibility for whl_library: Implemented conditional logic within the
_whl_library_implfunction to mark thewhl_libraryas reproducible. This occurs whenenable_pipstarandenable_pipstar_extractare true, and the repository context (rctx) supportsrepo_metadata. - Documentation Update: Updated the
whl_libraryrule's documentation to explicitly state that it is marked as reproducible under specific conditions, particularly when using Starlark for extraction without building ansdistfirst, effective from version 1.9.0.
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.
Changelog
- python/private/pypi/whl_library.bzl
- Implemented conditional logic within
_whl_library_implto mark the repository as reproducible whenpipstarextraction is enabled. - Updated the
whl_libraryrule's documentation to clarify when it is marked as reproducible, specifically mentioning version 1.9.0 and Starlark extraction.
- Implemented conditional logic within
Activity
- No activity to report on this pull request yet.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩