Missing osgi headers (#288) and added support for Apache Karaf by jmylly · Pull Request #458 · bbottema/simple-java-mail
Fixing issue where org.simplejavamail.internal.* are not exported in Osgi.
In addition, have Apache Karaf feature available.
Thank you for your effort. Question: is there a reason why you are using a nested a module named karaf-feaure? It deviated from how the other modules are configured in Maven.
Thank you for your effort. Question: is there a reason why you are using a nested a module named karaf-feaure? It deviated from how the other modules are configured in Maven.
For the future development, we could have each module as separate, installable karaf feature, like
|-- karaf-module
| |-- karaf-feature
| |-- karaf-feature-auth-socks
| |-- karaf-feature-dkim
| |-- karaf-feature-outlook
...
However, current PR doesn't have these submodules. I can also remove the submodule for now.
Ahh, I see. Yes, let's remove the nested module structure until we have multiple modules to nest. You're welcome to perform the change, else I will do it later this week. Thanks.
bbottema
changed the title
#288 missing osgi headers
#288 Missing osgi headers and added support for Apache Karaf
bbottema
changed the title
#288 Missing osgi headers and added support for Apache Karaf
Missing osgi headers (#288) and added support for Apache Karaf
Note, that for the next release, whenever that is, I'm renaming the module to karaf-module. Together with artifactGroup, that should be enough (as with the other modules).
So the dependency becomes org.simplejavamail:karaf-module:8.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters