Fix signal propagation by replacing init shell with nginx by uniquenode · Pull Request #30 · beevelop/docker-nginx-basic-auth
Navigation Menu
{{ message }}
beevelop / docker-nginx-basic-auth Public
- Notifications You must be signed in to change notification settings
- Fork 97
Merged
Fix signal propagation by replacing init shell with nginx#30
beevelop merged 1 commit intobeevelop:latestfrom
uniquenode:latest
Fix signal propagation by replacing init shell with nginx#30
beevelop merged 1 commit intobeevelop:latestfrom
uniquenode:latest
Conversation
Copy link
Contributor
uniquenode
commented
Sep 29, 2022
uniquenode
commented
Signals like SIGINT are sent to the init process. Currently these signals are not propagated to the nginx process, inhibiting a graceful shutdown. This PR fixes that by replacing the init shell with the nginx process, so that signals are sent to the nginx process instead.
Signed-off-by: Chris Lahaye <mail@chrislahaye.com>
beevelop approved these changes Jan 4, 2023
beevelop
merged commit
6afb1b8
into
beevelop:latest
beevelop
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants