BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861

BIP 350: Implement Bech32m and use it for v1+ segwit addresses by sipa · Pull Request #20861 · bitcoin/bitcoin

mentioned this pull request

Jan 5, 2021

sipa mentioned this pull request

Mar 18, 2021

fanquake added a commit that referenced this pull request

Mar 19, 2021

…ors.py

5c0210e bugfix: fix bech32_encode calls in gen_key_io_test_vectors.py (Pieter Wuille)

Pull request description:

  This fixes the the calls to bech32_encode in the gen_key_io_test_vectors.py script.

  Bug introduced in #20861.

ACKs for top commit:
  fanquake:
    ACK 5c0210e

Tree-SHA512: 8e8aee08741619c1700371ca1a8ca05ffdb2f48544d9fd3982f2665f6afb926b126478cf644f15a699f8c7e7da53c2777a56ce7989f05e4a3ef9fbe085f74d5a

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request

Mar 19, 2021

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

This also includes updates to the Python test framework implementation,
test vectors, and release notes.

Github-Pull: bitcoin#20861
Rebased-From: fe5e495

sipa pushed a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

This also includes updates to the Python test framework implementation,
test vectors, and release notes.

Github-Pull: bitcoin#20861
Rebased-From: fe5e495

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

sipa pushed a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

sipa added a commit to sipa/bitcoin that referenced this pull request

Mar 27, 2021

maflcko pushed a commit that referenced this pull request

Apr 1, 2021

…dresses (0.21 backport)

f2195d7 Backport invalid address tests (Pieter Wuille)
1e96711 naming nits (Fabian Jahr)
7dfe406 Add signet support to gen_key_io_test_vectors.py (Pieter Wuille)
593e206 Use Bech32m encoding for v1+ segwit addresses (Pieter Wuille)
8944aaa Add Bech32m test vectors (Pieter Wuille)
1485533 Implement Bech32m encoding/decoding (Pieter Wuille)

Pull request description:

  Backport of #20861. Also includes #21471.

ACKs for top commit:
  jnewbery:
    utACK f2195d7
  MarcoFalke:
    cherry-pick re-ACK f2195d7 , only change is version number in doc/bips and new test commit 🍝
  fanquake:
    ACK f2195d7 - performed the backport, changes look sane. Have not tested extensively.

Tree-SHA512: 7dc043e44d7cda07d73331a7b49666b9db98c99f2635dab0cfeb45422dbfbe75a7b44d0aff85ef6369d412d8a5041ed0826c86ffdfc13c5fbff74adfe4d91c1a

laanwj added a commit that referenced this pull request

Apr 23, 2021

…dresses (0.20 backport)

c0f85fd Backport invalid address tests (Pieter Wuille)
c670986 naming nits (Fabian Jahr)
1a4e88e Use Bech32m encoding for v1+ segwit addresses (Pieter Wuille)
cf18ac9 Add Bech32m test vectors (Pieter Wuille)
5f9537b Implement Bech32m encoding/decoding (Pieter Wuille)

Pull request description:

  Backport of #20861 for 0.20. Also includes #21471.

ACKs for top commit:
  jnewbery:
    utACK c0f85fd
  MarcoFalke:
    range-diff-only ACK c0f85fd 🐔

Tree-SHA512: e87e52995cb9b555109bc500dba1e844993d881821d2001443b3de9e3ef9050ddb73deefa0c1af732418fa7355a86b875789887c9611c340713b3ad26809d58e

apoelstra pushed a commit to apoelstra/elements that referenced this pull request

Aug 5, 2021

apoelstra pushed a commit to apoelstra/elements that referenced this pull request

Aug 5, 2021

apoelstra pushed a commit to apoelstra/elements that referenced this pull request

Aug 5, 2021

This also includes updates to the Python test framework implementation,
test vectors, and release notes.

bitcoin/bitcoin#20861 (3/5)

apoelstra pushed a commit to apoelstra/elements that referenced this pull request

Aug 18, 2021

apoelstra pushed a commit to apoelstra/elements that referenced this pull request

Aug 18, 2021

apoelstra pushed a commit to apoelstra/elements that referenced this pull request

Aug 18, 2021

This also includes updates to the Python test framework implementation,
test vectors, and release notes.

bitcoin/bitcoin#20861 (3/5)

apoelstra added a commit to ElementsProject/elements that referenced this pull request

Aug 30, 2021

c72c949 blech32: copy ubsan suppression for bech32 to blech32 (Andrew Poelstra)
d13fb49 blech32: add test vectors for blech32 and blech32m (Andrew Poelstra)
15a826e blech32: add functional tests for blech32m (Andrew Poelstra)
c01e09e blech32: add blech32m format and use it to decode witness v1+ addresses (Andrew Poelstra)
18fcec8 naming nits (Fabian Jahr)
8515f40 Add signet support to gen_key_io_test_vectors.py (Pieter Wuille)
b3df66f Use Bech32m encoding for v1+ segwit addresses (Pieter Wuille)
42f43a1 Add Bech32m test vectors (Pieter Wuille)
b1d1d94 Implement Bech32m encoding/decoding (Pieter Wuille)
c607835 Better error messages for invalid addresses (Bezdrighin)

Pull request description:

  Includes backports of bitcoin/bitcoin#20832 (1 commit) and bitcoin/bitcoin#20861 (5 commits)

ACKs for top commit:
  gwillen:
    utACK c72c949.

Tree-SHA512: af96a6ef31b1cab72b0350197dcb34761e9ffb2ec43685084408b5fafcda0adee1945045003194600372652f7cca65d721bda3ed9b6be7e9543d3199e2cbe145

bitcoin locked as resolved and limited conversation to collaborators

Aug 18, 2022