pnpm support added & fixed a lot of bugs like build command by BaderBC · Pull Request #276 · bitjson/typescript-starter
Navigation Menu
{{ message }}
bitjson / typescript-starter Public
- Notifications You must be signed in to change notification settings
- Fork 248
Open
pnpm support added & fixed a lot of bugs like build command#276
BaderBC wants to merge 4 commits intobitjson:masterfrom
pnpm support added & fixed a lot of bugs like build command#276
BaderBC wants to merge 4 commits intobitjson:masterfrom
Conversation
Copy link
BaderBC
commented
Mar 5, 2023
BaderBC
commented
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature:
I added pnpm tool support
Bug:
I fix a lot of bugs like wrong types, build problems etc.
-
What is the current behavior? (You can also link to an open issue here)
pnpmsupport as package manager #272 (no pnpm support)
moreover "npm run build" don't works -
What is the new behavior (if this is a feature change)?
you can use pnpm to create your project -
Other information:
I updated some packages to newer version
BaderBC
mentioned this pull request
BaderBC added 3 commits
March 6, 2023 07:31Copy link
Author
BaderBC
commented
Mar 6, 2023
BaderBC commented
Mar 6, 2023@bitjson
I fixed all errors, fixed scripts in package.json, added pnpm support and finally fixed all test, but still have no idea why your CI fails.
Could you do code review (optionally fix CI) and merge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment