pnpm support added & fixed a lot of bugs like build command by BaderBC · Pull Request #276 · bitjson/typescript-starter

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@BaderBC

Copy link

@BaderBC BaderBC commented

Mar 5, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature:
    I added pnpm tool support

Bug:
I fix a lot of bugs like wrong types, build problems etc.

  • What is the current behavior? (You can also link to an open issue here)
    pnpm support as package manager #272 (no pnpm support)
    moreover "npm run build" don't works

  • What is the new behavior (if this is a feature change)?
    you can use pnpm to create your project

  • Other information:
    I updated some packages to newer version

@BaderBC

Copy link

Author

BaderBC commented

Mar 6, 2023

@bitjson
I fixed all errors, fixed scripts in package.json, added pnpm support and finally fixed all test, but still have no idea why your CI fails.

Could you do code review (optionally fix CI) and merge?

sooohka and csskr reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BaderBC