Proposal for fixing custom bootstrap.less generator by mumia · Pull Request #301 · braincrafted/bootstrap-bundle
Navigation Menu
{{ message }}
braincrafted / bootstrap-bundle Public
- Notifications You must be signed in to change notification settings
- Fork 178
Merged
florianeckerstorfer merged 2 commits intobraincrafted:developfrom
Sep 18, 2014Merged
Conversation
Copy link Copy Markdown
Contributor
mumia
commented
Sep 11, 2014
mumia
commented
Refers #300
This works well in SF 2.5.4.
Copy link Copy Markdown
Member
florianeckerstorfer
commented
Sep 11, 2014
florianeckerstorfer commented
Sep 11, 2014Does this also work fine in Symfony < 2.5?
Copy link Copy Markdown
Member
florianeckerstorfer
commented
Sep 16, 2014
florianeckerstorfer commented
Sep 16, 2014@mumia Did you take a look at the failed test results? There seems to be a problem.
Copy link Copy Markdown
Contributor Author
mumia
commented
Sep 16, 2014
mumia commented
Sep 16, 2014@florianeckerstorfer no, I was in a hurry to finish the code I was working on.
But I will see what I broke and make sure it is fixed.
Copy link Copy Markdown
Member
florianeckerstorfer
commented
Sep 16, 2014
florianeckerstorfer commented
Sep 16, 2014As far as I can see you just forgot to adapt the tests.
mumia
force-pushed
the
issue300/generatorFailsForCustomVariable.less
branch
from
d7d3147 to
e7e4321
Compare
Copy link Copy Markdown
Contributor Author
mumia
commented
Sep 17, 2014
mumia commented
Sep 17, 2014@florianeckerstorfer Updated the tests and added some protection for older versions of symfony.
Should be ok now.
florianeckerstorfer pushed a commit that referenced this pull request
Sep 18, 2014…riable.less Proposal for fixing custom bootstrap.less generator
florianeckerstorfer
merged commit
f4ba62a
into
braincrafted:develop
florianeckerstorfer
mentioned this pull request
florianeckerstorfer
added this to the
2.1.1 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants