Switched twig extensions to use SimpleFunction/SimpleFilter by dkisselev · Pull Request #393 · braincrafted/bootstrap-bundle

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

florianeckerstorfer merged 1 commit intobraincrafted:developfrom

dkisselev:simple-function

Nov 4, 2015

Conversation

@dkisselev

Copy link Copy Markdown

Contributor

Previous methods have been deprecated as of Twig 1.28 1.21 and Symfony 2.7+ triggers
deprecation errors

Addresses more deprecations triggered by Symfony 2.7 (similar to issues identified in #377 & #378)

Previous methods have been deprecated as of Twig 1.28 and Symfony 2.7+ triggers
deprecation errors

florianeckerstorfer pushed a commit that referenced this pull request

Nov 4, 2015
Switch twig extensions to use SimpleFunction/SimpleFilter

@florianeckerstorfer florianeckerstorfer merged commit 55ae969 into braincrafted:develop

Nov 4, 2015

@fgrosse

Copy link Copy Markdown

fgrosse commented

Dec 2, 2015

We would really like to get rid of the deprecation warnings. Would you be willing to release this change soon (minor or hotfix version) so we don't have to depend on develop?

If you planned for a new regular release we could also wait a bit but it would be nice to know your schedule :)

@fgrosse

Copy link Copy Markdown

fgrosse commented

Dec 2, 2015

Oh I just saw #396 a bit too late. nvm then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkisselev @fgrosse @mobula9 @florianeckerstorfer