Replaced 'sameas' with 'same' (issue #414) by bartwesselink · Pull Request #417 · braincrafted/bootstrap-bundle
Navigation Menu
{{ message }}
braincrafted / bootstrap-bundle Public
- Notifications You must be signed in to change notification settings
- Fork 178
Merged
florianeckerstorfer merged 3 commits intobraincrafted:developfrom
bartwesselink:develop
Jan 22, 2016Merged
Replaced 'sameas' with 'same' (issue #414)#417
florianeckerstorfer merged 3 commits intobraincrafted:developfrom
bartwesselink:develop
Replaced 'sameas' with 'same' (issue #414)#417
florianeckerstorfer merged 3 commits intobraincrafted:developfrom
bartwesselink:develop
Conversation
Copy link Copy Markdown
Contributor
bartwesselink
commented
Jan 6, 2016
bartwesselink
commented
Replaced 'sameas' with 'same' (issue #414) to achieve Symfony 3.0 compability.
Copy link Copy Markdown
Contributor
dkisselev
commented
Jan 6, 2016
dkisselev commented
Jan 6, 2016Are you seeing any more deprecations in your apps after this fix? (just trying to ask everyone I can to get coverage)
Copy link Copy Markdown
Contributor Author
bartwesselink
commented
Jan 6, 2016
bartwesselink commented
Jan 6, 2016I will check on that tomorrow.
Copy link Copy Markdown
Contributor Author
bartwesselink
commented
Jan 8, 2016
bartwesselink commented
Jan 8, 2016I did not find one.
Copy link Copy Markdown
kYem
commented
Jan 13, 2016
kYem commented
Jan 13, 2016I though it should be same as rather than same
As per deprecation notice
Twig Test "sameas" is deprecated since version 1.21. Use "same as" instead in BraincraftedBootstrapBundle:Form:bootstrap.html.twig at line 39
maennchen and others added 2 commits
January 15, 2016 17:58
Copy link Copy Markdown
Contributor Author
bartwesselink
commented
Jan 15, 2016
bartwesselink commented
Jan 15, 2016Sorry. Did not see that. It should be fixed.
Copy link Copy Markdown
kYem
commented
Jan 22, 2016
kYem commented
Jan 22, 2016Can we get this merged in?
florianeckerstorfer pushed a commit that referenced this pull request
Jan 22, 2016Replace 'sameas' with 'same' (issue #414)
florianeckerstorfer
merged commit
003c0ad
into
braincrafted:develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants