Add a Painter variant of the placeholder APIs by sjudd · Pull Request #5296

Add a Painter variant of the placeholder APIs by sjudd · Pull Request #5296 · bumptech/glide

Conversation

We could go further and remove the drawable / resource id variants entirely, but it won't lead to a huge simplification internally because we still have to deal with those types from RequestBuilder.

sjudd mentioned this pull request

Sep 26, 2023

		@ExperimentalGlideComposeApi
		internal interface RequestListener {
		fun onStateChanged(model: Any?, drawable: Drawable?, requestState: RequestState)
		fun onStateChanged(model: Any?, painter: Painter?, requestState: RequestState)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun onStateChanged(model: Any?, painter: Painter?, requestState: RequestState)

Fixes #5224

We could go further and remove the drawable / resource id variants entirely, but it won't lead to a huge simplification internally because we still have to deal with those types from RequestBuilder.

Conversation

Choose a reason for hiding this comment

2 participants