sso-proxy: use internal/pkg/sessions by shrayolacrayon · Pull Request #137 · buzzfeed/sso
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 189
Merged
shrayolacrayon merged 1 commit intomasterfrom
Jan 18, 2019Merged
sso-proxy: use internal/pkg/sessions#137
shrayolacrayon merged 1 commit intomasterfrom
sso-proxy: use internal/pkg/sessions#137
shrayolacrayon merged 1 commit intomasterfrom
Conversation
Copy link
Changes all session store and csrf store logic to use internal/pkg/sessions.
Fixes #43.
RFR @buzzfeed/infra-security @buzzfeed/sso-maintainers
shrayolacrayon
force-pushed
the
shraya/sso-proxy-internal-sessionstate
branch
from
aee4fbb to
f432868
Compare
benjsto reviewed Jan 9, 2019
| func (ms *MockSessionStore) LoadSession(*http.Request) (*SessionState, error) { | ||
| if ms.Session == nil { | ||
| return nil, http.ErrNoCookie | ||
| } |
Copy link
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty trivial but might be cleaner and more concise to to set ms.LoadError to http.ErrNoCookie here?
katzdm previously approved these changes Jan 16, 2019
benjsto previously approved these changes Jan 16, 2019
sporkmonger
mentioned this pull request
shrayolacrayon
dismissed stale reviews from benjsto and katzdm
via
4713a33
shrayolacrayon
force-pushed
the
shraya/sso-proxy-internal-sessionstate
branch
from
9f32476 to
4713a33
Compare
loganmeetsworld approved these changes Jan 18, 2019
shrayolacrayon
merged commit
97b15cb
into
master
shrayolacrayon
deleted the
shraya/sso-proxy-internal-sessionstate
branch
sporkmonger
mentioned this pull request
jphines
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants