proxy: default allowed groups by jphines · Pull Request #148 · buzzfeed/sso
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 189
Merged
Conversation
Copy link
Contributor
jphines
commented
Jan 24, 2019
jphines
commented
Problem
We have the need to specify default allowed groups
Solution
Allow us to specify default allowed groups via env config for every upstream.
Notes
Needs some tests.
Copy link
Contributor
loganmeetsworld
commented
Jan 24, 2019
loganmeetsworld commented
Jan 24, 2019gonna need to add
internal/proxy/options.go:118:16: unknown field 'DefaultGroups' in struct literal of type Options
jphines
force-pushed
the
default-allowed-groups
branch
10 times, most recently
from
6ae9d2a to
65caf4c
Compare
jphines
force-pushed
the
default-allowed-groups
branch
from
65caf4c to
20ee9b9
Compare
shrayolacrayon approved these changes Jan 24, 2019
jphines
merged commit
4fed3dc
into
master
jphines
deleted the
default-allowed-groups
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants