auth: update google version endpoints by jphines · Pull Request #216 · buzzfeed/sso
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 189
Merged
Conversation
Copy link
Contributor
jphines
commented
Jun 19, 2019
jphines
commented
Problem
Updates the version of some of the google provider endpoints + some generic google provider cleanups.
jphines added 2 commits
June 19, 2019 12:00Copy link
codecov
bot
commented
Jun 19, 2019
codecov bot commented
Jun 19, 2019Codecov Report
Merging #216 into master will increase coverage by
0.01%.
The diff coverage is57.14%.
@@ Coverage Diff @@ ## master #216 +/- ## ========================================== + Coverage 61.19% 61.21% +0.01% ========================================== Files 50 50 Lines 4069 4071 +2 ========================================== + Hits 2490 2492 +2 - Misses 1392 1393 +1 + Partials 187 186 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| internal/auth/providers/provider_data.go | 100% <ø> (ø) |
⬆️ |
| internal/auth/providers/provider_default.go | 0% <ø> (ø) |
⬆️ |
| internal/auth/configuration.go | 49.73% <ø> (ø) |
⬆️ |
| internal/auth/options.go | 78.57% <100%> (+2.38%) |
⬆️ |
| internal/auth/providers/google.go | 58.49% <48.27%> (-0.71%) |
⬇️ |
Jusshersmith
self-requested a review
Jusshersmith approved these changes Jun 24, 2019
jphines
merged commit
568049a
into
master
jphines
deleted the
update-google-version-endpoints
branch
Jusshersmith
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment