auth: update google version endpoints by jphines · Pull Request #216 · buzzfeed/sso

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jphines

Copy link

Contributor

@jphines jphines commented

Jun 19, 2019

Problem

Updates the version of some of the google provider endpoints + some generic google provider cleanups.

@codecov

Copy link

codecov bot commented

Jun 19, 2019

Codecov Report

Merging #216 into master will increase coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   61.19%   61.21%   +0.01%     
==========================================
  Files          50       50              
  Lines        4069     4071       +2     
==========================================
+ Hits         2490     2492       +2     
- Misses       1392     1393       +1     
+ Partials      187      186       -1
Impacted Files Coverage Δ
internal/auth/providers/provider_data.go 100% <ø> (ø) ⬆️
internal/auth/providers/provider_default.go 0% <ø> (ø) ⬆️
internal/auth/configuration.go 49.73% <ø> (ø) ⬆️
internal/auth/options.go 78.57% <100%> (+2.38%) ⬆️
internal/auth/providers/google.go 58.49% <48.27%> (-0.71%) ⬇️

@Jusshersmith Jusshersmith self-requested a review

June 24, 2019 15:12

@jphines jphines merged commit 568049a into master

Jun 24, 2019

@jphines jphines deleted the update-google-version-endpoints branch

June 24, 2019 15:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jusshersmith Jusshersmith Jusshersmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jphines @Jusshersmith