sso_auth: make `provider_*_okta_server` optional by kjetijor · Pull Request #292 · buzzfeed/sso

Conversation

@kjetijor

Problem

Quickstart (and testing in practice) seems to indicate that PROVIDER_*_OKTA_SERVER should be optional, if you wish to use the default okta authorization server.

If you are not using the default Okta authorization server you will also need to add PROVIDER_OKTAQUICKSTART_SERVER_ID= to the above file.

Solution

Make it optional!

Notes

Kjetil Joergensen added 2 commits

April 29, 2020 17:18
The quickstart seems to indicate that this is optional

@codecov

Jusshersmith

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kjetijor,

Thank you contributing and fixing this!

@Jusshersmith Jusshersmith changed the title PROVIDER_*_OKTA_SERVER optional sso_auth: make provider_*_okta_server optional

May 1, 2020

2 participants

@kjetijor @Jusshersmith