wasmprinter: print end offsets with closing parenthesis by keithw · Pull Request #2315 · bytecodealliance/wasm-tools

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@keithw

Copy link

Contributor

@keithw keithw commented

Sep 20, 2025

Followup of #2312. This is a purely cosmetic change that puts the offsets for function-end and module-end on the same line as the closing parenthesis.

@keithw keithw requested a review from a team as a code owner

September 20, 2025 08:51

@keithw keithw requested review from abrown and removed request for a team

September 20, 2025 08:51

@keithw keithw force-pushed the printer-end-offsets branch from 9e0fa81 to 93c076a Compare

September 20, 2025 09:01
Copy link

Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@alexcrichton alexcrichton added this pull request to the merge queue

Sep 20, 2025

Merged via the queue into bytecodealliance:main with commit a64ae8d

Sep 20, 2025

34 checks passed

@keithw keithw deleted the printer-end-offsets branch

September 20, 2025 22:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@abrown abrown Awaiting requested review from abrown abrown is a code owner automatically assigned from bytecodealliance/wasm-tools-default-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keithw @alexcrichton