[wit-dylib] add `[async-lower]` prefix to `read` and `write` imports by dicej · Pull Request #2371 · bytecodealliance/wasm-tools
I realized that some of my `componentize-py` tests weren't actually testing what
they were supposed to, and that was due to the `{stream|future}.{read|write}`
intrinsics being lowered synchronously 🤦. This fixes that.
Note that we're still lowering the `{stream|future}.cancel-{read|write}`
intrinsics synchronously, same as the Rust `wit-bindgen` does. We might need to
change that (or make it configurable) for toolchains that actually have a good
async cancellation paradigm.
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej added a commit to dicej/componentize-py that referenced this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej added a commit to dicej/componentize-py that referenced this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
mentioned this pull request
dicej
deleted the
async-read-write
branch
dicej added a commit to dicej/componentize-py that referenced this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej added a commit to bytecodealliance/componentize-py that referenced this pull request
Nov 10, 2025
Due to the `wit-dylib` issue that bytecodealliance/wasm-tools#2371 addresses, these tests weren't actually testing what I thought they were. Fixing that revealed a couple of bugs involving stream writes, which this fixes. Also, bump version to 0.19.2 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
mxgordon pushed a commit to YellowPapayas/wasm-tools that referenced this pull request
Nov 11, 2025
…iance#2371) I realized that some of my `componentize-py` tests weren't actually testing what they were supposed to, and that was due to the `{stream|future}.{read|write}` intrinsics being lowered synchronously 🤦. This fixes that. Note that we're still lowering the `{stream|future}.cancel-{read|write}` intrinsics synchronously, same as the Rust `wit-bindgen` does. We might need to change that (or make it configurable) for toolchains that actually have a good async cancellation paradigm. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters