Home Original page

Make the success message shorter by eoghanmurray · Pull Request #80 · changesets/bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@eoghanmurray

Copy link Copy Markdown

Make the success message shorter than the failure message and tweak the visuals to better distinguish the two.

Ref #79

@vercel

Copy link Copy Markdown

vercel bot commented

Nov 7, 2023

•

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changesets-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 3:51pm

@eoghanmurray

Copy link Copy Markdown

Author

  • in the absent version, does the getReleasePlanMessage(releasePlan) always return the 'when changesets are added to this PR...' message? If so, then that could be inlined and made visually distinctive (rather than both messages having a bit that is expandable)
  • I looked at the git log but couldn't really see the reason for including the ${commitSha} in either the absent or the approve message; removing from only the approve message for brevity
…re important than the butterflies, as the butterfly is already there in the bot icon

@eoghanmurray

Copy link Copy Markdown

Author

What current iteration of ths PR looks like:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatown emmatown Awaiting requested review from emmatown emmatown is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eoghanmurray