Detect package manager from package.json before lockfiles by clockwork-labs-bot · Pull Request #4814 · clockworklabs/SpacetimeDB

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@clockwork-labs-bot

Copy link Copy Markdown

Collaborator

Fixes #4713.

Summary

  • detect the package manager from package.json's packageManager field before falling back to lockfiles
  • keep the existing lockfile fallback order (pnpm-lock.yaml, yarn.lock, bun.lock*, package-lock.json)
  • preserve the existing npm fallback when a project has package.json but no package-manager signal

Testing

  • cargo test -p spacetimedb-cli package_manager -- --nocapture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bfops bfops Awaiting requested review from bfops bfops is a code owner

@cloutiertyler cloutiertyler Awaiting requested review from cloutiertyler cloutiertyler is a code owner

@jdetter jdetter Awaiting requested review from jdetter jdetter is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

spacetime dev hardcodes 'npm run dev' without detecting package manager in existing projects

1 participant

@clockwork-labs-bot