BREAKING CHANGE: use string instead of enum for `Version` by lance · Pull Request #561 · cloudevents/sdk-javascript
TypeScript does not consider enum values equivalent, even if the string representation is the same. So, when a module imports `cloudevents` and also has a dependency on `cloudevents` this can cause conflicts where the `CloudEvent.version` attribute is not considered equal when, in fact, it is. Changing the `enum` to a string is pretty straightforward, but should be considered a breaking change since TypeScript dependents will potentially fail the build with a change like this. Signed-off-by: Lance Ball <lball@redhat.com>
lance added a commit to lance/sdk-javascript that referenced this pull request
Jul 20, 2023This is an empty commit that provides a reference to cloudevents#561 which was not considered a breaking change by release-please. Release-As: 8.0.0 Signed-off-by: Lance Ball <lball@redhat.com>
lance
mentioned this pull request
lholmquist pushed a commit that referenced this pull request
Jul 20, 2023This is an empty commit that provides a reference to #561 which was not considered a breaking change by release-please. Release-As: 8.0.0 Signed-off-by: Lance Ball <lball@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters