chore: Update compatible node version by tnunamak · Pull Request #573 · cloudevents/sdk-javascript
Navigation Menu
{{ message }}
cloudevents / sdk-javascript Public
- Notifications You must be signed in to change notification settings
- Fork 76
Merged
chore: Update compatible node version#573
lholmquist merged 2 commits intocloudevents:mainfrom
chore: Update compatible node version#573
lholmquist merged 2 commits intocloudevents:mainfrom
Conversation
Copy link
Contributor
tnunamak
commented
Dec 4, 2023
tnunamak
commented
Proposed Changes
This indicates compatibility with Node.js 21.
Signed-off-by: Tim Nunamaker <tim@vana.com>
lholmquist requested changes Dec 4, 2023
Copy link
Contributor
lholmquist
left a comment
lholmquist
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also add node 21 to the CI matrix https://github.com/cloudevents/sdk-javascript/blob/main/.github/workflows/nodejs-ci-action.yml#L18
lholmquist approved these changes Dec 4, 2023
Copy link
Contributor
lholmquist
left a comment
lholmquist
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just need to sign that last commit to pass that DCO check
Signed-off-by: Tim Nunamaker <tim@vana.com>
tnunamak
force-pushed
the
patch-1
branch
from
aa4c6ca to
d38e03e
Compare
lholmquist
merged commit
245bae9
into
cloudevents:main
lholmquist
mentioned this pull request
tnunamak
deleted the
patch-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants