Upgrade js-yaml to avoid Denial of Service by Teamop · Pull Request #39 · cloudfoundry-community/node-cfenv
Navigation Menu
{{ message }}
cloudfoundry-community / node-cfenv Public
- Notifications You must be signed in to change notification settings
- Fork 23
Merged
Upgrade js-yaml to avoid Denial of Service#39
pmuellr merged 1 commit intocloudfoundry-community:masterfrom
Teamop:fix-js-yaml
Upgrade js-yaml to avoid Denial of Service#39
pmuellr merged 1 commit intocloudfoundry-community:masterfrom
Teamop:fix-js-yaml
Conversation
Copy link Copy Markdown
Contributor
Teamop
commented
Mar 22, 2019
Teamop
commented
Based on the npm audit, there is an security issue with js-yaml, so upgrade to the latest version to fix.
And with the latest js-yaml version, all the test cases can still pass.
pmuellr approved these changes Mar 25, 2019
Copy link Copy Markdown
Member
pmuellr
left a comment
pmuellr
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the PR!
pmuellr
merged commit
3f19f12
into
cloudfoundry-community:master
Copy link Copy Markdown
Member
pmuellr
commented
Mar 25, 2019
pmuellr commented
Mar 25, 2019Now available on npm as version 1.2.1 - https://www.npmjs.com/package/cfenv
Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants