Make AWS creds optional: langfuse/measures edition by snickell · Pull Request #71274 · code-dot-org/code-dot-org
Conversation
We want dashboard to boot up without having AWS credentials.
This PR makes the following secrets not loaded at boot time on development:
CDO.openai_measures_of_learning_api_keyCDO.langfuse_secret_keyCDO.langfuse_public_key
Yay we get to have our cake and eat it too! 🥳
- They are still loaded at boot in prod/staging/test as required keys, and those environments should auto raise an exception if they're not present.
- We don't need to cache the value because
CDO.*already caches secrets for us.
Testing
Untested beyond drone.
snickell
changed the title
Make AWS optional for Erin deployment
Make AWS creds optional: langfuse/measures edition
| @@ -1,6 +1,5 @@ | |||
| module OpenaiPersonalizationHelper | |||
| # NEED TO CHANGE THIS KEY | |||
| API_KEY = CDO.openai_measures_of_learning_api_key | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm less concerned about the change you made, @snickell and more about the comment that this key needs to change... @code-dot-org/teacher-tools is there a different OpenAI key in place for personalization?
@Erin007 Yes, scanned the other PR and analogous changes look like they'd be suitable. Are you rather close to merging that PR? It would unblock me today if we could merge this one in the interim, although I know that'll require resolving a merge conflict on your branch.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No opposition from me! Thanks for picking this up.
snickell
deleted the
seth/make-aws-optional-erin
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters