…gressions

Bugs fixed:
- clock-o (outline) was mapped to fa-solid fa-clock → now fa-regular fa-clock
  in CodeWorkspace, WebLabView, DataWorkspace, DesignModeHeaders, JavalabEditorHeader
- thumbs-o-up (outline) now uses iconStyle="regular" in ValidationStep.jsx
- manage_assets.feature selector now matches AssetThumbnail source (both use circle-play)

Canonical v7 renames:
- volume-up → volume-high (InlineAudio)
- play-circle → circle-play, pause-circle → circle-pause (AssetThumbnail, SoundListEntry,
  PauseButton, SoundListEntryTest, manage_assets.feature)
- check-circle → circle-check (Notification, DanceAiModal, DanceAiScore, JavalabEditorHeader)
- pencil → pen (LevelToken, LessonToken)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adding iconStyle to the destructured params without a default value
caused TypeScript to infer it as required, breaking all existing TSX
callers (EditCondition, EditValidation, Loading, SoundsPanel, PanelsView)
that don't pass iconStyle.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The bare 'fa' prefix only works via v4 shims. Defaulting to 'fa-solid'
makes the component v7-native so it will continue working when v4 shims
are eventually removed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

These callers were not in the original codemod diff but still used v4
icon names that depend on v4-shims to resolve:

- comments-o → comments (regular) in CodeReviewTimelineReview
- files-o → copy (regular) in AddLevelTableRow
- pencil-square-o → pen-to-square in DataDocEditAll
- pencil → pen in FocusAreaIndicator
- " fa-times-circle" → circle-xmark in SectionActionDropdown (also fixed
  malformed icon name with leading space and fa- prefix)
- arrow-circle-left → circle-arrow-left in DataTableView
- cog → gear in MakerStatusOverlay
- exclamation-triangle → triangle-exclamation in MakerStatusOverlay
- play-circle → circle-play in SoundsPanel

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Tests were still using old v4 CSS class selectors after the codemod
migrated icon names in source files:
- MakerStatusOverlayTest: fa-cog→fa-gear, fa-exclamation-triangle→fa-triangle-exclamation
- LessonTokenTest: fa-pencil→fa-pen, fa-arrows-v→fa-up-down, fa-times→fa-xmark
- script_edit_page.feature: fa-pencil→fa-pen (caused UI test timeout)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

These 7 dynamic/conditional icon usages were skipped by the automated
codemod because they use ternaries or variable lookups. Each has been
manually updated to use v7 icon names and styles:

- BackgroundMusicMuteButton: volume-off → volume-xmark, fa → fa-solid prefix
- LessonGroup: info-circle → circle-info
- ReferenceGuideEditAll: pencil-square-o → pen-to-square (regular)
- ProgressLegend: file-text → file-lines, video-camera → video
- LessonTip: lightbulb-o → lightbulb (regular)
- PreviewPaneHeader: arrows-alt → up-down-left-right (commented code)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The FontAwesomeV6Icon 'close' alias no longer resolves to 'xmark' in
v7. This caused the UI test selector '.fa-xmark' to fail because the
rendered class was 'fa-close'. Update both usages to use the canonical
v7 name 'xmark'.

Fixes failing Cucumber test: ai_evaluate_student_code.feature

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

These were flagged as dynamic icon usages by the codemod (ternaries,
variable lookups) and need manual migration. The UI test selectors
were already updated to v7 names but the source code still used v4
names, causing the tests to fail.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The codemod skipped this dynamic ternary usage. The icon names were
already updated to v7 (circle-play/circle-pause) but the class prefix
was still the v4 'fa' instead of 'fa-solid'.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Revert "chore: migrate FA v4 icon references to v7 (#71308)"

This reverts commit 956c0f7.

* Reapply "chore: migrate FA v4 icon references to v7 (#71308)"

This reverts commit 7262161.

* fix: update icon references in SendLesson and ItemType components

* feat: migrate Comment component to use FontAwesomeV6Icon

* fix: update icon references in ValidationStep and AssetRowTest for FontAwesome v7

* fix: update icon references in BooleanPropertyRow, submissions_download_form, ControlButtons, HelpTip, and ModalHelpTip for FontAwesome v7

* fix: update icon references from question-circle to circle-question for FontAwesome v7

* fix: update icon references in _single_multi.html.haml for FontAwesome v7

* fix: update BooleanPropertyRow to use FontAwesomeV6Icon for checkbox rendering

* fix: update icon references in LessonProgress.story.jsx for FontAwesome v7

* Revert "Revert "chore: migrate FA v4 icon references to v7 (#71308)" (#71395)"

This reverts commit 316fd74

* fix: update Facebook and Twitter icon styles for FontAwesome v7

* fix: update WireframeButtons and DataDocEditAll to use FontAwesomeV6Icon

* fix: update BubbleBadge to use regular FontAwesome icon style

* fix: update icon usage in UnassignedStudentsPanel and SendLesson for FontAwesome v7

* fix: update Twitter share button label to reflect rebranding to X

* fix: remove bold font weight from header styles

* fix: remove bold font weight from header styles

* fix: update JsDebugger to wrap icon in a div and adjust SCSS for FontAwesome usage

* revert locales updates

* fix unit tests

* fix: add iconStyleProp to Button component for consistent icon styling

* fix: update icon class for toggle button in ec_design.js

---------

Co-authored-by: Liam Frye-Mason <liam.fryemason@code.org>