move signin-callout ui tests off of production courses by davidsbailey · Pull Request #71586 · code-dot-org/code-dot-org
Conversation
The reason for this change is to make UI tests no longer depend on production courses. For background, see partitioned curriculum data proposal.
Done as part of this PR:
- added a new
ui-test-csfunit / course / course offering via levelbuilder UI- mark the unit as 'CSF' to trigger the sign in callout here:
show_sign_in_callout: csf? || csc?,
- mark the unit as 'CSF' to trigger the sign in callout here:
- update signin-callout ui tests to use new course
- stop seeding the following courses / units in test:
express-2017andpre-express-2017(already unused)coursea-2020(freed up by this PR)
Testing story
- drone shows new ui test is passing
- the
[reset db]commit tag ensures we properly test removal of ui test courses + units from seed.rake
davidsbailey
changed the title
remove some csf units from ui test config
move signin-callout ui tests off of production courses
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice- and thank you! What a throwback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters