Bugfix/291 iconborderwidth doesnt work by codebude · Pull Request #351 · Shane32/QRCoder
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 1.2k
Merged
Merged
Conversation
Copy link
Collaborator
Summary
This PR fixes/implements the following bugs:
- The icon's border wasn't rendered (due to a former code removal, which made the parameter useless)
- The previous method for border rendering was refactored, to work without Region.Exclude(path) (which earlier led to problems on Linux environments)
- More testcases were written and existing ones improved
Test plan
Closing issues
Fixes #291
codebude added 2 commits
November 23, 2021 22:46
codebude
merged commit
f10daa1
into
master
codebude
deleted the
bugfix/291-iconborderwidth-doesnt-work
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant