ASCIQRCode Small by hbdbim · Pull Request #384 · Shane32/QRCoder

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hbdbim

Copy link

Contributor

@hbdbim hbdbim commented

Feb 4, 2022

Implementation of a new method that generates a small qrcode.
Inspired by the repository https://github.com/gtanner/qrcode-terminal.

Implemented a basic test function (can_render_small_ascii_qrcode).

Fixes #379

Credits for qrcode-terminal.
Credits for qrcode-terminal.
Credits for qrcode-terminal.

@codebude

Copy link

Collaborator

I added some more test cases, cleaned up the code a little bit and added an invert-feature as seen in #430 .
Testcases passed successfully.
Documentation was updated: https://github.com/codebude/QRCoder/wiki/Advanced-usage---QR-Code-renderers/_compare/ca6705e9ca20592f08d2a12c6f5674f0f5baa1c3...4c64be0c071dcadcbc5f97e3779afab86c224744

Thanks for your PR @hbdbim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shane32 Shane32 Shane32 approved these changes

+1 more reviewer

@RobertoMK RobertoMK RobertoMK approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AsciiQRCode-Renderer

4 participants

@hbdbim @codebude @Shane32 @RobertoMK