Feature/392 fix and improve payment payload generator validation by codebude · Pull Request #498 · Shane32/QRCoder

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@codebude

Copy link

Collaborator

Summary

This PR fixes a validator bug in PaymentOrder payload generator. In contrast to the standard document the payload generator checked the complete payload against a 300 byte length limit whereas the standard defined that only the mandatory fields should stay within the 300 byte limit.

Closing issues

fixes #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

it's required fields that should not exceed 300, not optional + required

1 participant

@codebude